diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-02-21 17:05:26 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-02-21 19:14:18 -0800 |
commit | b7ba8587c3f8b9e54461a7914e13441dc659c92f (patch) | |
tree | 0734247b59078211ef00ed60ff962c0046d8f01d /t/t5515/refs.br-remote-glob | |
parent | The sixth batch (diff) | |
download | tgif-b7ba8587c3f8b9e54461a7914e13441dc659c92f.tar.xz |
git-compat-util.h: clarify GCC v.s. C99-specific in comment
Change a comment added in e208f9cc757 (make error()'s constant return
value more visible, 2012-12-15). It's not correct that this is GCC-ism
anymore, it's code that uses standard C99 features.
The comment being changed here pre-dates the HAVE_VARIADIC_MACROS
define, which we got in e05bed960d3 (trace: add 'file:line' to all
trace output, 2014-07-12).
The original implementation of an error() macro) in e208f9cc757 used a
GCC-ism with the paste operator (see the commit message for mention of
it), but that was dropped later by 9798f7e5f9 (Use __VA_ARGS__ for all
of error's arguments, 2013-02-08), giving us the C99-portable version
we have now.
While we could remove the __GNUC__ define here, it might cause issues
for other compilers or static analysis systems, so let's not. See
87fe5df365 (inline constant return from error() function, 2014-05-06)
for one such issue.
See also e05bed960d3 (trace: add 'file:line' to all trace output,
2014-07-12) for another comment about GNUC's handling of __VA_ARGS__.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5515/refs.br-remote-glob')
0 files changed, 0 insertions, 0 deletions