diff options
| author |  Pratik Karki <predatoramigo@gmail.com> | 2018-03-27 23:16:37 +0545 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-03-28 09:30:14 -0700 |
| commit | a4d4e32a700df92ca576ce89110c075b8ce6da75 (patch) | |
| tree | 4f991815ba071fc8849314f248018d1054a7ef99 /t/t5510-fetch.sh | |
| parent | Git 2.16.3 (diff) | |
| download | tgif-a4d4e32a700df92ca576ce89110c075b8ce6da75.tar.xz | |
test: avoid pipes in git related commands for test
Avoid using pipes downstream of Git commands since the exit codes
of commands upstream of pipes get swallowed, thus potentially
hiding failure of those commands. Instead, capture Git command
output to a file and apply the downstream command(s) to that file.
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5510-fetch.sh')
| -rwxr-xr-x | t/t5510-fetch.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh index 3debc87d4a..ad3bd086a4 100755 --- a/t/t5510-fetch.sh +++ b/t/t5510-fetch.sh @@ -690,8 +690,8 @@ test_expect_success C_LOCALE_OUTPUT 'fetch aligned output' ' test_commit looooooooooooong-tag && ( cd full-output && - git -c fetch.output=full fetch origin 2>&1 | \ - grep -e "->" | cut -c 22- >../actual + git -c fetch.output=full fetch origin >actual 2>&1 && + grep -e "->" actual | cut -c 22- >../actual ) && cat >expect <<-\EOF && master -> origin/master @@ -705,8 +705,8 @@ test_expect_success C_LOCALE_OUTPUT 'fetch compact output' ' test_commit extraaa && ( cd compact && - git -c fetch.output=compact fetch origin 2>&1 | \ - grep -e "->" | cut -c 22- >../actual + git -c fetch.output=compact fetch origin >actual 2>&1 && + grep -e "->" actual | cut -c 22- >../actual ) && cat >expect <<-\EOF && master -> origin/* |