diff options
author | Junio C Hamano <gitster@pobox.com> | 2021-07-28 10:07:02 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-07-28 10:57:37 -0700 |
commit | 1fcc40cd1dbfbdf6879a7b60a3a0250e46dc5c60 (patch) | |
tree | fa5a5c99d04357d11b207d937711cfcaa46357cc /t/t5411/test-0024-report-unknown-ref.sh | |
parent | bisect: do not run show-branch just to show the current commit (diff) | |
download | tgif-1fcc40cd1dbfbdf6879a7b60a3a0250e46dc5c60.tar.xz |
bisect: simplify return code from bisect_checkout()
The function was designed to return only BISECT_OK (0) or
BISECT_FAILED (-1) and no other values, but there were two issues:
- The comment misspelled BISECT_FAILED as BISECT_FAILURE, even
though the logic it described (i.e. any non-zero return should be
reported as a single BISECT_FAILED) was correct.
- It took the return value from run_command_v_opt(), and assumed it
was either -1 or 1 upon error, which is not the case; it can relay
errors from wait_or_whine(), which can report exit status of the
child process.
Translate any error return from run_command_v_opt() to BISECT_FAILED,
and simplify the resulting code by losing the 'res' variable that is
no longer needed.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5411/test-0024-report-unknown-ref.sh')
0 files changed, 0 insertions, 0 deletions