diff options
author | Jeff King <peff@peff.net> | 2013-04-05 18:21:34 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-04-06 18:56:44 -0700 |
commit | 67d2a7b5c502496b0c5acd25a5e0ffa766b61745 (patch) | |
tree | d3f222a51f9a56905428dd7bab1c36b9d0d33016 /t/t5100/info-from.expect | |
parent | remote-curl: consistently report repo url for http errors (diff) | |
download | tgif-67d2a7b5c502496b0c5acd25a5e0ffa766b61745.tar.xz |
http: simplify http_error helper function
This helper function should really be a one-liner that
prints an error message, but it has ended up unnecessarily
complicated:
1. We call error() directly when we fail to start the curl
request, so we must later avoid printing a duplicate
error in http_error().
It would be much simpler in this case to just stuff the
error message into our usual curl_errorstr buffer
rather than printing it ourselves. This means that
http_error does not even have to care about curl's exit
value (the interesting part is in the errorstr buffer
already).
2. We return the "ret" value passed in to us, but none of
the callers actually cares about our return value. We
can just drop this entirely.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5100/info-from.expect')
0 files changed, 0 insertions, 0 deletions