summaryrefslogtreecommitdiff
path: root/t/t5001-archive-attr.sh
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2020-10-07 14:19:43 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-10-07 11:51:26 -0700
commitbebe1719470078b000950b0cca520d3e533996a9 (patch)
tree69fb80ba123d2adce96bc657c6d51921004d4c77 /t/t5001-archive-attr.sh
parentindex-pack: restore "resolving deltas" progress meter (diff)
downloadtgif-bebe1719470078b000950b0cca520d3e533996a9.tar.xz
index-pack: drop type_cas mutex
The type_cas lock lost all of its callers in f08cbf60fe (index-pack: make quantum of work smaller, 2020-09-08), so we can safely delete it. The compiler didn't alert us that the variable became unused, because we still call pthread_mutex_init() and pthread_mutex_destroy() on it. It's worth considering also whether that commit was in error to remove the use of the lock. Why don't we need it now, if we did before, as described in ab791dd138 (index-pack: fix race condition with duplicate bases, 2014-08-29)? I think the answer is that we now look at and assign the child_obj->real_type field in the main thread while holding the work_lock(). So we don't have to worry about racing with the worker threads. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5001-archive-attr.sh')
0 files changed, 0 insertions, 0 deletions