diff options
author | SZEDER Gábor <szeder.dev@gmail.com> | 2018-08-19 23:57:22 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-08-21 11:48:29 -0700 |
commit | ec10b018e76b3f4f40db96a24202c6b8c056bd0f (patch) | |
tree | fca8ac2204c583b2aec884c7a87541f11d117735 /t/t4211-line-log.sh | |
parent | tests: make use of the test_must_be_empty function (diff) | |
download | tgif-ec10b018e76b3f4f40db96a24202c6b8c056bd0f.tar.xz |
tests: use 'test_must_be_empty' instead of '! test -s'
Using 'test_must_be_empty' is preferable to '! test -s', because it
gives a helpful error message if the given file is unexpectedly not
empty, while the latter remains completely silent. Furthermore, it
also catches cases when the given file unexpectedly does not exist at
all.
This patch was basically created by:
sed -i -e 's/! test -s/test_must_be_empty/' t[0-9]*.sh
with the following notable exceptions:
- The '! test -s' check in '.gitmodules ignore=dirty suppresses
submodules with untracked content' in 't7508-status.sh' is left
as-is, because it's bogus and, therefore, it's subject of a
dedicated patch.
- The '! test -s' checks in 't9131-git-svn-empty-symlink.sh' and
't9135-git-svn-moved-branch-empty-file.sh' are immediately
preceeded by a 'test -f' to ensure that the files exist in the
first place. 'test_must_be_empty' ensures that as well, so those
'test -f' commands are removed as well.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4211-line-log.sh')
0 files changed, 0 insertions, 0 deletions