diff options
author | Carlo Marcelo Arenas Belón <carenas@gmail.com> | 2019-10-16 12:10:23 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-10-18 10:33:18 +0900 |
commit | 513f2b0bbd47015640723a10210c527839e8946a (patch) | |
tree | e987d87ffac2e5e7637acc3392442fc7d3b3d02f /t/t4112-apply-renames.sh | |
parent | grep: make PCRE1 aware of custom allocator (diff) | |
download | tgif-513f2b0bbd47015640723a10210c527839e8946a.tar.xz |
grep: make PCRE2 aware of custom allocator
94da9193a6 (grep: add support for PCRE v2, 2017-06-01) didn't include
a way to override the system allocator, and so it is incompatible with
custom allocators (e.g. nedmalloc). This problem became obvious when we
tried to plug a memory leak by `free()`ing a data structure allocated by
PCRE2, triggering a segfault in Windows (where we use nedmalloc by
default).
PCRE2 requires the use of a general context to override the allocator
and therefore, there is a lot more code needed than in PCRE1, including
a couple of wrapper functions.
Extend the grep API with a "destructor" that could be called to cleanup
any objects that were created and used globally.
Update `builtin/grep.c` to use that new API, but any other future users
should make sure to have matching `grep_init()`/`grep_destroy()` calls
if they are using the pattern matching functionality.
Move some of the logic that was before done per thread (in the workers)
into an earlier phase to avoid degrading performance, but as the use of
PCRE2 with custom allocators is better understood it is expected more of
its functions will be instructed to use the custom allocator as well as
was done in the original code[1] this work was based on.
[1] https://public-inbox.org/git/3397e6797f872aedd18c6d795f4976e1c579514b.1565005867.git.gitgitgadget@gmail.com/
Reported-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4112-apply-renames.sh')
0 files changed, 0 insertions, 0 deletions