diff options
author | Alban Gruin <alban.gruin@gmail.com> | 2019-11-24 18:43:32 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-11-25 12:24:49 +0900 |
commit | 393adf7a6f600adca8cb75ec4e7136d523e8840d (patch) | |
tree | 8d59d40e46fe011e7f7814bc0355909f7b25d98d /t/t4100 | |
parent | rebase: fill `squash_onto' in get_replay_opts() (diff) | |
download | tgif-393adf7a6f600adca8cb75ec4e7136d523e8840d.tar.xz |
sequencer: directly call pick_commits() from complete_action()
Currently, complete_action(), used by builtin/rebase.c to start a new
rebase, calls sequencer_continue() to do it. Before the former calls
pick_commits(), it
- calls read_and_refresh_cache() -- this is unnecessary here as we've
just called require_clean_work_tree() in complete_action()
- calls read_populate_opts() -- this is unnecessary as we're starting a
new rebase, so `opts' is fully populated
- loads the todo list -- this is unnecessary as we've just populated
the todo list in complete_action()
- commits any staged changes -- this is unnecessary as we're starting a
new rebase, so there are no staged changes
- calls record_in_rewritten() -- this is unnecessary as we're starting
a new rebase.
This changes complete_action() to directly call pick_commits() to avoid
these unnecessary steps.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4100')
0 files changed, 0 insertions, 0 deletions