diff options
author | Jeff King <peff@peff.net> | 2016-12-14 10:10:10 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-12-14 09:58:09 -0800 |
commit | 87433261a46db1a9bd012acd7fba868f009ba38f (patch) | |
tree | 466f8a12f40f7152157487685aa6118e1527b8f9 /t/t4053-diff-no-index.sh | |
parent | Prepare for 2.9.4 (diff) | |
download | tgif-87433261a46db1a9bd012acd7fba868f009ba38f.tar.xz |
parse-options: print "fatal:" before usage_msg_opt()
Programs may use usage_msg_opt() to print a brief message
followed by the program usage, and then exit. The message
isn't prefixed at all, though, so it doesn't match our usual
error output and is easy to overlook:
$ git clone 1 2 3
Too many arguments.
usage: git clone [<options>] [--] <repo> [<dir>]
-v, --verbose be more verbose
-q, --quiet be more quiet
--progress force progress reporting
-n, --no-checkout don't create a checkout
--bare create a bare repository
[...and so on for another 31 lines...]
It looks especially bad when the message starts with an
option, like:
$ git replace -e
-e needs exactly one argument
usage: git replace [-f] <object> <replacement>
or: git replace [-f] --edit <object>
[...etc...]
Let's put our usual "fatal:" prefix in front of it.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4053-diff-no-index.sh')
0 files changed, 0 insertions, 0 deletions