diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2019-07-26 17:08:17 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-07-26 13:56:40 -0700 |
commit | 870eea81669bfff4333b37b11fedd870cd05fd90 (patch) | |
tree | a0e89650008caa4fba2890dabdc7a087953f6159 /t/t4018/golang-func | |
parent | grep: stess test PCRE v2 on invalid UTF-8 data (diff) | |
download | tgif-870eea81669bfff4333b37b11fedd870cd05fd90.tar.xz |
grep: do not enter PCRE2_UTF mode on fixed matching
As discussed in the last commit partially fix a bug introduced in
b65abcafc7 ("grep: use PCRE v2 for optimized fixed-string search",
2019-07-01). Because PCRE v2, unlike kwset, validates its UTF-8 input
we'd die on e.g.:
fatal: pcre2_match failed with error code -22: UTF-8 error:
isolated byte with 0x80 bit set
When grepping a non-ASCII fixed string. This is a more general problem
that's hard to fix, but we can at least fix the most common case of
grepping for a fixed string without "-i". I can't think of a reason
for why we'd turn on PCRE2_UTF when matching byte-for-byte like that.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4018/golang-func')
0 files changed, 0 insertions, 0 deletions