summaryrefslogtreecommitdiff
path: root/t/t4018/css-common
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2020-11-20 09:52:26 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-11-24 14:11:17 -0800
commita6d8d1103633f295ce6f738dcd5221389e8d5fd2 (patch)
treeae146da347dfcbba075a8da47d2701d0363ac89a /t/t4018/css-common
parentGit 2.29.2 (diff)
downloadtgif-a6d8d1103633f295ce6f738dcd5221389e8d5fd2.tar.xz
MyFirstContribition: answering questions is not the end of the story
A review exchange may begin with a reviewer asking "what did you mean by this phrase in your log message (or here in the doc)?", the author answering what was meant, and then the reviewer saying "ah, that is what you meant---then the flow of the logic makes sense". But that is not the happy end of the story. New contributors often forget that the material that has been reviewed in the above exchange is still unclear in the same way to the next person who reads it, until it gets updated. While we are in the vicinity, rephrase the verb "request" used to refer to comments by reviewers to "suggest"---this matches the contrast between "original" and "suggested" that appears later in the same paragraph, and more importantly makes it clearer that it is not like authors are to please reviewers' wishes but rather reviewers are merely helping authors to polish their commits. Reviewed-by: Emily Shaffer <emilyshaffer@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4018/css-common')
0 files changed, 0 insertions, 0 deletions