summaryrefslogtreecommitdiff
path: root/t/t4018/cpp-class-definition-derived
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2015-12-17 01:47:07 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-12-17 10:47:56 -0800
commit728350b76a2244e7cf79412f46e990e763ebf89e (patch)
treeeaccb4628faf5958536a690a0fe0169235f528c5 /t/t4018/cpp-class-definition-derived
parenttraverse_commit_list: support pending blobs/trees with paths (diff)
downloadtgif-728350b76a2244e7cf79412f46e990e763ebf89e.tar.xz
revision.c: propagate tag names from pending array
When we unwrap a tag to find its commit for a traversal, we do not propagate the "name" field of the tag in the pending array (i.e., the ref name the user gave us in the first place) to the commit (instead, we use an empty string). This means that "git log --source" will never show the tag-name for commits we reach through it. This was broken in 2073949 (traverse_commit_list: support pending blobs/trees with paths, 2014-10-15). That commit tried to be careful and avoid propagating the path information for a tag (which would be nonsensical) to trees and blobs. But it should not have cut off the "name" field, which should carry forward to children. Note that this does mean that the "name" field will carry forward to blobs and trees, too. Whereas prior to 2073949, we always gave them an empty string. This is the right thing to do, but in practice no callers probably use it (since now we have an explicit separate "path" field, which was the point of 2073949). We add tests here not only for the broken case, but also a basic sanity test of "log --source" in general, which did not have any coverage in the test suite. Reported-by: Raymundo <gypark@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4018/cpp-class-definition-derived')
0 files changed, 0 insertions, 0 deletions