diff options
| author |  Jeff King <peff@peff.net> | 2016-09-12 20:23:27 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-09-13 15:45:45 -0700 |
| commit | 475b362c2a326ddc9987ee0ff6448e795f009d5d (patch) | |
| tree | bd7ef92925e525e1d4860e2751d8cbef96956139 /t/t4013/diff.whatchanged_--root_--cc_--patch-with-stat_--summary_master | |
| parent | patch-id: use RUN_SETUP_GENTLY (diff) | |
| download | tgif-475b362c2a326ddc9987ee0ff6448e795f009d5d.tar.xz | |
diff: skip implicit no-index check when given --no-index
We can invoke no-index mode in two ways: by an explicit
request from the user, or implicitly by noticing that we
have two paths, and at least one is outside the repository.
If the user already told us --no-index, there is no need for
us to do the implicit test at all. However, we currently
do, and downgrade our "explicit" to DIFF_NO_INDEX_IMPLICIT.
This doesn't have any user-visible behavior, though it's not
immediately obvious why. We only trigger the implicit check
when we have exactly two non-option arguments. And the only
code that cares about implicit versus explicit is an error
message that we show when we _don't_ have two non-option
arguments.
However, it's worth fixing anyway. Besides being slightly
more efficient, it makes the code easier to follow, which
will help when we modify it in future patches.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.whatchanged_--root_--cc_--patch-with-stat_--summary_master')
0 files changed, 0 insertions, 0 deletions