diff options
author | Derrick Stolee <dstolee@microsoft.com> | 2020-04-16 20:14:02 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-04-16 15:38:02 -0700 |
commit | 8918e379aac11b1e2ed7bb5be8433516c4ff5e8f (patch) | |
tree | c1b8abdd97dd885b238876172bf51deba4ff245a /t/t4013/diff.rev-list_--parents_HEAD | |
parent | bloom: ignore renames when computing changed paths (diff) | |
download | tgif-8918e379aac11b1e2ed7bb5be8433516c4ff5e8f.tar.xz |
revision: complicated pathspecs disable filters
The changed-path Bloom filters work only when we can compute an
explicit Bloom filter key in advance. When a pathspec is given
that allows case-insensitive checks or wildcard matching, we
must disable the Bloom filter performance checks.
By checking the pathspec in prepare_to_use_bloom_filters(), we
avoid setting up the Bloom filter data and thus revert to the
usual logic.
Before this change, the following tests would fail*:
t6004-rev-list-path-optim.sh (Tests 6-7)
t6130-pathspec-noglob.sh (Tests 3-6)
t6131-pathspec-icase.sh (Tests 3-5)
*These tests would fail when using GIT_TEST_COMMIT_GRAPH and
GIT_TEST_COMMIT_GRAPH_BLOOM_FILTERS except that the latter
environment variable was not set up correctly to write the changed-
path Bloom filters in the test suite. That will be fixed in the
next change.
Helped-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.rev-list_--parents_HEAD')
0 files changed, 0 insertions, 0 deletions