diff options
author | Elijah Newren <newren@gmail.com> | 2020-11-05 00:22:39 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-11-04 17:09:49 -0800 |
commit | b70c82e6edd33aa03afecd52b0265cf1d9762e1b (patch) | |
tree | 7cb46f485783ecbd672b16aa015820764e8349f3 /t/t4013/diff.format-patch_--stdout_--numbered_initial..master | |
parent | strmap: new utility functions (diff) | |
download | tgif-b70c82e6edd33aa03afecd52b0265cf1d9762e1b.tar.xz |
strmap: add more utility functions
This adds a number of additional convienence functions I want/need:
* strmap_get_size()
* strmap_empty()
* strmap_remove()
* strmap_for_each_entry()
* strmap_get_entry()
I suspect the first four are self-explanatory.
strmap_get_entry() is similar to strmap_get() except that instead of just
returning the void* value that the string maps to, it returns the
strmap_entry that contains both the string and the void* value (or
NULL if the string isn't in the map). This is helpful because it avoids
multiple lookups, e.g. in some cases a caller would need to call:
* strmap_contains() to check that the map has an entry for the string
* strmap_get() to get the void* value
* <do some work to update the value>
* strmap_put() to update/overwrite the value
If the void* pointer returned really is a pointer, then the last step is
unnecessary, but if the void* pointer is just cast to an integer then
strmap_put() will be needed. In contrast, one can call strmap_get_entry()
and then:
* check if the string was in the map by whether the pointer is NULL
* access the value via entry->value
* directly update entry->value
meaning that we can replace two or three hash table lookups with one.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.format-patch_--stdout_--numbered_initial..master')
0 files changed, 0 insertions, 0 deletions