diff options
| author |  Johannes Sixt <j6t@kdbg.org> | 2011-06-06 09:06:02 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2011-06-06 11:35:06 -0700 |
| commit | 06bc4b796ad69ba93f0a8c451368602e0553c2d3 (patch) | |
| tree | c3134457df1903f61b973273f0e0114f544afa83 /t/t4013/diff.format-patch_--attach_--stdout_initial..master^ | |
| parent | sh-i18n--envsubst: do not crash when no arguments are given (diff) | |
| download | tgif-06bc4b796ad69ba93f0a8c451368602e0553c2d3.tar.xz | |
mingw.c: move definition of mingw_getenv down
We want to use static lookup_env() in a subsequent change.
At first sight, this change looks innocent. But it is not due to the
#undef getenv. There is one caller of getenv between the old location and
the new location whose behavior could change. But as can be seen from the
defintion of mingw_getenv, the behavior for this caller does not change
substantially.
To ensure consistent behavior in the future, change all getenv callers
in mingw.c to use mingw_getenv.
With this patch, this is not a big deal, yet, but with the subsequent
change, where we teach getenv to do a case-sensitive lookup, the behavior
of all call sites is changed.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.format-patch_--attach_--stdout_initial..master^')
0 files changed, 0 insertions, 0 deletions