diff options
author | Jeff King <peff@peff.net> | 2017-03-28 15:46:56 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-03-30 14:59:50 -0700 |
commit | 1a168e5c86d2c6cbb57429473357bdf1acdec63c (patch) | |
tree | 7a22f1e29fad8eb65e1fb7e9eec01bd10c37716b /t/t4013/diff.diff_-r_initial..side | |
parent | combine-diff: replace malloc/snprintf with xstrfmt (diff) | |
download | tgif-1a168e5c86d2c6cbb57429473357bdf1acdec63c.tar.xz |
convert unchecked snprintf into xsnprintf
These calls to snprintf should always succeed, because their
input is small and fixed. Let's use xsnprintf to make sure
this is the case (and to make auditing for actual truncation
easier).
These could be candidates for turning into heap buffers, but
they fall into a few broad categories that make it not worth
doing:
- formatting single numbers is simple enough that we can
see the result should fit
- the size of a sha1 is likewise well-known, and I didn't
want to cause unnecessary conflicts with the ongoing
process to convert these constants to GIT_MAX_HEXSZ
- the interface for curl_errorstr is dictated by curl
Signed-off-by: Jeff King <peff@peff.net>
Diffstat (limited to 't/t4013/diff.diff_-r_initial..side')
0 files changed, 0 insertions, 0 deletions