summaryrefslogtreecommitdiff
path: root/t/t4013/diff.diff_--no-index_--name-status_dir2_dir
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2013-03-29 15:51:55 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2013-03-29 15:13:53 -0700
commit53ca053b3062e985f6270570b42471fbeb2dd6a5 (patch)
treebeea5ccf628051a8a62902b4c30ddc45990a0037 /t/t4013/diff.diff_--no-index_--name-status_dir2_dir
parentMerge branch 'yd/use-test-config-unconfig' (diff)
downloadtgif-53ca053b3062e985f6270570b42471fbeb2dd6a5.tar.xz
t1300: document some aesthetic failures of the config editor
The config-editing code used by "git config var value" is built around the regular config callback parser, whose only triggerable item is an actual key. As a result, it does not know anything about section headers, which can result in unnecessarily ugly output: 1. When we delete the last key in a section, we should be able to delete the section header. 2. When we add a key into a section, we should be able to reuse the same section header, even if that section did not have any keys in it already. Unfortunately, fixing these is not trivial with the current code. It would involve the config parser recording and passing back information on each item it finds, including headers, keys, and even comments (or even better, generating an actual in-memory parse-tree). Since these behaviors do not cause any functional problems (i.e., the resulting config parses as expected, it is just uglier than one would like), fixing them can wait until somebody feels like substantially refactoring the parsing code. In the meantime, let's document them as known issues with some tests. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.diff_--no-index_--name-status_dir2_dir')
0 files changed, 0 insertions, 0 deletions