diff options
| author |  Jeff King <peff@peff.net> | 2012-07-23 14:48:57 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2012-07-23 13:10:43 -0700 |
| commit | 447b99c8b1102746054644acd268f4c1b115a9f8 (patch) | |
| tree | 8a8eedaa50f8ccaf477d0341648dd0b8465a6bb1 /t/t4013/diff.diff-tree_-c_--stat_--summary_master | |
| parent | Git 1.7.9.7 (diff) | |
| download | tgif-447b99c8b1102746054644acd268f4c1b115a9f8.tar.xz | |
advice: pass varargs to strbuf_vaddf, not strbuf_addf
The advise() function takes a variable number of arguments
and converts them into a va_list object to pass to strbuf
for handling. However, we accidentally called strbuf_addf
(that takes a variable number of arguments) instead of
strbuf_vaddf (that takes a va_list).
This bug dates back to v1.7.8.1-1-g23cb5bf, but we never
noticed because none of the current callers passes a string
with a format specifier in it. And the compiler did not
notice because the format string is not available at
compile time.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.diff-tree_-c_--stat_--summary_master')
0 files changed, 0 insertions, 0 deletions