diff options
author | Jakub Narebski <jnareb@gmail.com> | 2008-10-02 16:50:04 +0200 |
---|---|---|
committer | Shawn O. Pearce <spearce@spearce.org> | 2008-10-02 17:43:18 -0700 |
commit | 2d7a3532c78bace2f3631ab0e594f713dcab9916 (patch) | |
tree | 4ff26626ddd74f9ee7657fb4f222f9f4ab72b675 /t/t4013/diff.diff-tree_--pretty_-p_initial | |
parent | Solaris: Use OLD_ICONV to avoid compile warnings (diff) | |
download | tgif-2d7a3532c78bace2f3631ab0e594f713dcab9916.tar.xz |
gitweb: Fix two 'uninitialized value' warnings in git_tree()
If we did try to access nonexistent directory or file, which means
that git_get_hash_by_path() returns `undef`, uninitialized $hash
variable was passed to 'open' call. Now we fail early with "404 Not
Found - No such tree" error. (If we try to access something which
does not resolve to tree-ish, for example a file / 'blob' object, the
error will be caught later, as "404 Not Found - Reading tree failed"
error).
If we tried to use 'tree' action without $file_name ('f' parameter)
set, which means either tree given by hash or a top tree (and we
currently cannot distinguish between those two cases), we cannot print
path breadcrumbs with git_print_page_path(). Fix this by moving call
to git_print_page_path() inside conditional.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Acked-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Diffstat (limited to 't/t4013/diff.diff-tree_--pretty_-p_initial')
0 files changed, 0 insertions, 0 deletions