diff options
author | Steve Hoelzer <shoelzer@gmail.com> | 2018-10-31 14:11:36 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-11-05 13:02:42 +0900 |
commit | e8dfcace316aaaca226c2ae2d268bcc4d3131b38 (patch) | |
tree | 8baa89194ed437fdaf34c0eed80241d080afc219 /t/t3701-add-interactive.sh | |
parent | Seventh batch for 2.20 (diff) | |
download | tgif-e8dfcace316aaaca226c2ae2d268bcc4d3131b38.tar.xz |
poll: use GetTickCount64() to avoid wrap-around issues
The value of timeout starts as an int value, and for this reason it
cannot overflow unsigned long long aka ULONGLONG. The unsigned version
of this initial value is available in orig_timeout. The difference
(orig_timeout - elapsed) cannot wrap around because it is protected by
a conditional (as can be seen in the patch text). Hence, the ULONGLONG
difference can only have values that are smaller than the initial
timeout value and truncation to int cannot overflow.
Signed-off-by: Steve Hoelzer <shoelzer@gmail.com>
[j6t: improved both implementation and log message]
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t3701-add-interactive.sh')
0 files changed, 0 insertions, 0 deletions