diff options
author | Duy Nguyen <pclouds@gmail.com> | 2018-11-03 07:03:18 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-11-06 13:22:30 +0900 |
commit | 13374987dd889858758afef458bd8a8cbf15bb4d (patch) | |
tree | b3f47bff1bc37a7230d158b2c8d436fc068f19b9 /t/t2102-update-index-symlinks.sh | |
parent | Fifth batch for 2.20 (diff) | |
download | tgif-13374987dd889858758afef458bd8a8cbf15bb4d.tar.xz |
completion: use __gitcomp_builtin for format-patch
This helps format-patch gain completion for a couple new options,
notably --range-diff.
Since send-email completion relies on $__git_format_patch_options
which is now reduced, we need to do something not to regress
send-email completion.
The workaround here is implement --git-completion-helper in
send-email.perl just as a bridge to "format-patch --git-completion-helper".
This is enough to use __gitcomp_builtin on send-email (to take
advantage of caching).
In the end, send-email.perl can probably reuse the same info it passes
to GetOptions() to generate full --git-completion-helper output so
that we don't need to keep track of its options in git-completion.bash
anymore. But that's something for another boring day.
Helped-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t2102-update-index-symlinks.sh')
0 files changed, 0 insertions, 0 deletions