diff options
author | Jeff King <peff@peff.net> | 2010-12-13 12:02:25 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2010-12-20 10:28:19 -0800 |
commit | 4579bb418c2995a8459de7dba42b63a26006f9a6 (patch) | |
tree | 578b3d9b4643c2a789ca355f5974822d7eaefb8c /t/t2100-update-cache-badpath.sh | |
parent | gitweb: Include links to feeds in HTML header only for '200 OK' response (diff) | |
download | tgif-4579bb418c2995a8459de7dba42b63a26006f9a6.tar.xz |
ident: die on bogus date format
If the user gives "git commit --date=foobar", we silently
ignore the --date flag. We should note the error.
This patch puts the fix at the lowest level of fmt_ident,
which means it also handles GIT_AUTHOR_DATE=foobar, as well.
There are two down-sides to this approach:
1. Technically this breaks somebody doing something like
"git commit --date=now", which happened to work because
bogus data is the same as "now". Though we do
explicitly handle the empty string, so anybody passing
an empty variable through the environment will still
work.
If the error is too much, perhaps it can be downgraded
to a warning?
2. The error checking happens _after_ the commit message
is written, which can be annoying to the user. We can
put explicit checks closer to the beginning of
git-commit, but that feels a little hack-ish; suddenly
git-commit has to care about how fmt_ident works. Maybe
we could simply call fmt_ident earlier?
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t2100-update-cache-badpath.sh')
0 files changed, 0 insertions, 0 deletions