diff options
author | Jeff King <peff@peff.net> | 2015-08-10 05:35:31 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-08-10 15:37:12 -0700 |
commit | fcd12db6af118b70b5c15cf5fdd6800eeecc370a (patch) | |
tree | 8050bcc9515081c8a6a52285297fe23f0bf08916 /t/t1404-update-ref-df-conflicts.sh | |
parent | add_to_alternates_file: don't add duplicate entries (diff) | |
download | tgif-fcd12db6af118b70b5c15cf5fdd6800eeecc370a.tar.xz |
prefer git_pathdup to git_path in some possibly-dangerous cases
Because git_path uses a static buffer that is shared with
calls to git_path, mkpath, etc, it can be dangerous to
assign the result to a variable or pass it to a non-trivial
function. The value may change unexpectedly due to other
calls.
None of the cases changed here has a known bug, but they're
worth converting away from git_path because:
1. It's easy to use git_pathdup in these cases.
2. They use constructs (like assignment) that make it
hard to tell whether they're safe or not.
The extra malloc overhead should be trivial, as an
allocation should be an order of magnitude cheaper than a
system call (which we are clearly about to make, since we
are constructing a filename). The real cost is that we must
remember to free the result.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1404-update-ref-df-conflicts.sh')
0 files changed, 0 insertions, 0 deletions