summaryrefslogtreecommitdiff
path: root/t/t1305-config-include.sh
diff options
context:
space:
mode:
authorLibravatar Tanay Abhra <tanayabh@gmail.com>2014-08-18 03:17:57 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-08-18 10:45:59 -0700
commitc8466645edd1413c7efed824f5bddac457eb77f9 (patch)
tree1e0aa1584d4b7155e56f62bead24136ef54f8cde /t/t1305-config-include.sh
parentGit 2.0.4 (diff)
downloadtgif-c8466645edd1413c7efed824f5bddac457eb77f9.tar.xz
make config --add behave correctly for empty and NULL values
Currently if we have a config file like, [foo] baz bar = and we try something like, "git config --add foo.baz roll", Git will segfault. Moreover, for "git config --add foo.bar roll", it will overwrite the original value instead of appending after the existing empty value. The problem lies with the regexp used for simulating --add in `git_config_set_multivar_in_file()`, "^$", which in ideal case should not match with any string but is true for empty strings. Instead use a regexp like "a^" which can not be true for any string, empty or not. For removing the segfault add a check for NULL values in `matches()` in config.c. Signed-off-by: Tanay Abhra <tanayabh@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1305-config-include.sh')
0 files changed, 0 insertions, 0 deletions