diff options
author | Paul Tan <pyokagan@gmail.com> | 2015-08-19 16:22:22 +0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-08-19 10:51:39 -0700 |
commit | 3ecc7040eff29fea0051df9faf21b0a73ee6d911 (patch) | |
tree | fbe6086d2dfcf89395832c6e957f182864e32060 /t/t1302-repo-version.sh | |
parent | git-am: add am.threeWay config variable (diff) | |
download | tgif-3ecc7040eff29fea0051df9faf21b0a73ee6d911.tar.xz |
am --skip/--abort: merge HEAD/ORIG_HEAD tree into index
After running "git am --abort", and then running "git reset --hard",
files that were not modified would still be re-checked out.
This is because clean_index() in builtin/am.c mistakenly called the
read_tree() function, which overwrites all entries in the index,
including the stat info.
"git am --skip" did not seem to have this issue because am_skip() called
am_run(), which called refresh_cache() to update the stat info. However,
there's still a performance penalty as the lack of stat info meant that
refresh_cache() would have to scan all files for changes.
Fix this by using unpack_trees() instead to merge the tree into the
index, so that the stat info from the index is kept.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Paul Tan <pyokagan@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1302-repo-version.sh')
0 files changed, 0 insertions, 0 deletions