summaryrefslogtreecommitdiff
path: root/t/t1001-read-tree-m-2way.sh
diff options
context:
space:
mode:
authorLibravatar John Keeping <john@keeping.me.uk>2014-02-16 16:06:05 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-02-18 15:51:56 -0800
commitd954828d45efbd4b53576e86066657e87391318d (patch)
treee9863eead8a070c6a3c60932f28463b7d9506bfe /t/t1001-read-tree-m-2way.sh
parentutf8: use correct type for values in interval table (diff)
downloadtgif-d954828d45efbd4b53576e86066657e87391318d.tar.xz
builtin/mv: don't use memory after free
If 'src' already ends with a slash, then add_slash() will just return it, meaning that 'free(src_with_slash)' is actually 'free(src)'. Since we use 'src' later, this will result in use-after-free. In fact, this cannot happen because 'src' comes from internal_copy_pathspec() without the KEEP_TRAILING_SLASH flag, so any trailing '/' will have been stripped; but static analysis tools are not clever enough to realise this and so warn that 'src' could be used after having been free'd. Fix this by checking that 'src_w_slash' is indeed newly allocated memory. Signed-off-by: John Keeping <john@keeping.me.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1001-read-tree-m-2way.sh')
0 files changed, 0 insertions, 0 deletions