diff options
author | SZEDER Gábor <szeder.dev@gmail.com> | 2019-04-05 02:45:36 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-04-05 15:02:06 +0900 |
commit | 9219d12777baf67e001329cad98fa21c55d46b2e (patch) | |
tree | 4c85f52b2ec35902d63c1169ffdf034ec04d134d /t/t0026-eol-config.sh | |
parent | mingw: allow building with an MSYS2 runtime v3.x (diff) | |
download | tgif-9219d12777baf67e001329cad98fa21c55d46b2e.tar.xz |
progress: make display_progress() return void
Ever since the progress infrastructure was introduced in 96a02f8f6d
(common progress display support, 2007-04-18), display_progress() has
returned an int, telling callers whether it updated the progress bar
or not. However, this is:
- useless, because over the last dozen years there has never been a
single caller that cared about that return value.
- not quite true, because it doesn't print a progress bar when
running in the background, yet it returns 1; see 85cb8906f0
(progress: no progress in background, 2015-04-13).
The related display_throughput() function returned void already upon
its introduction in cf84d51c43 (add throughput to progress display,
2007-10-30).
Let's make display_progress() return void, too. While doing so
several return statements in display() become unnecessary, remove
them.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t0026-eol-config.sh')
0 files changed, 0 insertions, 0 deletions