summaryrefslogtreecommitdiff
path: root/t/t0019-json-writer.sh
diff options
context:
space:
mode:
authorLibravatar Taylor Blau <me@ttaylorr.com>2021-08-24 12:15:56 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-08-24 13:21:13 -0700
commit1d7f7f242c89947c3f0bc0ade651e614a2f0a38f (patch)
treee396065a9717d178af2a273efc903b60163e2e14 /t/t0019-json-writer.sh
parentpack-bitmap-write.c: gracefully fail to write non-closed bitmaps (diff)
downloadtgif-1d7f7f242c89947c3f0bc0ade651e614a2f0a38f.tar.xz
pack-bitmap-write.c: free existing bitmaps
When writing a new bitmap, the bitmap writer code attempts to read the existing bitmap (if one is present). This is done in order to quickly permute the bits of any bitmaps for commits which appear in the existing bitmap, and were also selected for the new bitmap. But since this code was added in 341fa34887 (pack-bitmap-write: use existing bitmaps, 2020-12-08), the resources associated with opening an existing bitmap were never released. It's fine to ignore this, but it's bad hygiene. It will also cause a problem for the multi-pack-index builtin, which will be responsible not only for writing bitmaps, but also for expiring any old multi-pack bitmaps. If an existing bitmap was reused here, it will also be expired. That will cause a problem on platforms which require file resources to be closed before unlinking them, like Windows. Avoid this by ensuring we close reused bitmaps with free_bitmap_index() before removing them. Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t0019-json-writer.sh')
0 files changed, 0 insertions, 0 deletions