summaryrefslogtreecommitdiff
path: root/t/t0005-signals.sh
diff options
context:
space:
mode:
authorLibravatar Derrick Stolee <dstolee@microsoft.com>2020-02-21 21:47:28 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-02-22 09:23:08 -0800
commit3e96c66805f17d7345eba4733bc80c6fe646b95f (patch)
treec3442700de8118cf7e577ad6b236241371913dd7 /t/t0005-signals.sh
parentpartial-clone: demonstrate bugs in partial fetch (diff)
downloadtgif-3e96c66805f17d7345eba4733bc80c6fe646b95f.tar.xz
partial-clone: avoid fetching when looking for objects
When using partial clone, find_non_local_tags() in builtin/fetch.c checks each remote tag to see if its object also exists locally. There is no expectation that the object exist locally, but this function nevertheless triggers a lazy fetch if the object does not exist. This can be extremely expensive when asking for a commit, as we are completely removed from the context of the non-existent object and thus supply no "haves" in the request. 6462d5eb9a (fetch: remove fetch_if_missing=0, 2019-11-05) removed a global variable that prevented these fetches in favor of a bitflag. However, some object existence checks were not updated to use this flag. Update find_non_local_tags() to use OBJECT_INFO_SKIP_FETCH_OBJECT in addition to OBJECT_INFO_QUICK. The _QUICK option only prevents repreparing the pack-file structures. We need to be extremely careful about supplying _SKIP_FETCH_OBJECT when we expect an object to not exist due to updated refs. This resolves a broken test in t5616-partial-clone.sh. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t0005-signals.sh')
0 files changed, 0 insertions, 0 deletions