diff options
| author |  Jeff Hostetler <jeffhost@microsoft.com> | 2021-10-04 22:29:03 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2021-10-04 22:01:08 -0700 |
| commit | b9e4d84878b5c14fd4bd6e94e4e7d9ed0fc95c69 (patch) | |
| tree | 9f60ce0f85d1e5c858b88287a9d001ac6e6995b1 /t/perf | |
| parent | The tenth batch (diff) | |
| download | tgif-b9e4d84878b5c14fd4bd6e94e4e7d9ed0fc95c69.tar.xz | |
t/perf/perf-lib.sh: remove test_times.* at the end test_perf_()
Teach test_perf_() to remove the temporary test_times.* files
at the end of each test.
test_perf_() runs a particular GIT_PERF_REPEAT_COUNT times and creates
./test_times.[123...]. It then uses a perl script to find the minimum
over "./test_times.*" (note the wildcard) and writes that time to
"test-results/<testname>.<testnumber>.result".
If the repeat count is changed during the pXXXX test script, stale
test_times.* files (from previous steps) may be included in the min()
computation. For example:
...
GIT_PERF_REPEAT_COUNT=3 \
test_perf "status" "
git status
"
GIT_PERF_REPEAT_COUNT=1 \
test_perf "checkout other" "
git checkout other
"
...
The time reported in the summary for "XXXX.2 checkout other" would
be "min( checkout[1], status[2], status[3] )".
We prevent that error by removing the test_times.* files at the end of
each test.
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/perf')
| -rw-r--r-- | t/perf/perf-lib.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index f5ed092ee5..a1b5d2804d 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -230,6 +230,7 @@ test_perf_ () { test_ok_ "$1" fi "$TEST_DIRECTORY"/perf/min_time.perl test_time.* >"$base".result + rm test_time.* } test_perf () { |