diff options
author | Jeff King <peff@peff.net> | 2017-09-05 09:05:01 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-09-06 18:06:26 +0900 |
commit | 1fb2b636c672fea06fdc5f50d5c0ed44117ae45a (patch) | |
tree | 5569c294402e712b73b4e4743d3bc9518a75a3ca /t/perf/repos/inflate-repo.sh | |
parent | repository: free fields before overwriting them (diff) | |
download | tgif-1fb2b636c672fea06fdc5f50d5c0ed44117ae45a.tar.xz |
set_git_dir: handle feeding gitdir to itself
Ideally we'd free the existing gitdir field before assigning
the new one, to avoid a memory leak. But we can't do so
safely because some callers do the equivalent of:
set_git_dir(get_git_dir());
We can detect that case as a noop, but there are even more
complicated cases like:
set_git_dir(remove_leading_path(worktree, get_git_dir());
where we really do need to do some work, but the original
string must remain valid.
Rather than put the burden on callers to make a copy of the
string (only to free it later, since we'll make a copy of it
ourselves), let's solve the problem inside set_git_dir(). We
can make a copy of the pointer for the old gitdir, and then
avoid freeing it until after we've made our new copy.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/perf/repos/inflate-repo.sh')
0 files changed, 0 insertions, 0 deletions