summaryrefslogtreecommitdiff
path: root/t/helper
diff options
context:
space:
mode:
authorLibravatar René Scharfe <l.s.r@web.de>2019-08-07 13:15:20 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-08-07 12:26:35 -0700
commit7df3bd462a7e8cd18f16ae33acc49fac15db7c3e (patch)
treefc463e049753ee52d2621e344680cc2225aeee25 /t/helper
parentdir-iterator: release strbuf after use (diff)
downloadtgif-7df3bd462a7e8cd18f16ae33acc49fac15db7c3e.tar.xz
test-dir-iterator: use path argument directly
Avoid allocating and leaking a strbuf for holding a verbatim copy of the path argument and pass the latter directly to dir_iterator_begin() instead. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper')
-rw-r--r--t/helper/test-dir-iterator.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/t/helper/test-dir-iterator.c b/t/helper/test-dir-iterator.c
index a5b96cb0dc..b421d2bf38 100644
--- a/t/helper/test-dir-iterator.c
+++ b/t/helper/test-dir-iterator.c
@@ -10,7 +10,6 @@
*/
int cmd__dir_iterator(int argc, const char **argv)
{
- struct strbuf path = STRBUF_INIT;
struct dir_iterator *diter;
unsigned int flags = 0;
int iter_status;
@@ -27,8 +26,7 @@ int cmd__dir_iterator(int argc, const char **argv)
if (!*argv || argc != 1)
die("dir-iterator needs exactly one non-option argument");
- strbuf_add(&path, *argv, strlen(*argv));
- diter = dir_iterator_begin(path.buf, flags);
+ diter = dir_iterator_begin(*argv, flags);
if (!diter) {
printf("dir_iterator_begin failure: %d\n", errno);