diff options
author | Greg Hurrell <greg@hurrell.net> | 2021-06-09 21:28:06 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-06-10 09:49:20 +0900 |
commit | a45e390ad6ad1f26967a40e7771777f70a77d719 (patch) | |
tree | 921d33096db6608c89f227dfd0be3d01786bf57f /t/helper/test-userdiff.c | |
parent | Git 2.31.1 (diff) | |
download | tgif-a45e390ad6ad1f26967a40e7771777f70a77d719.tar.xz |
gitweb: use HEAD as secondary sort key in git_get_heads_list()
The "heads" section on the gitweb summary page shows heads in
`-committerdate` order (ie. the most recently-modified ones at the
top), tie-breaking equal-dated refs using the implicit `refname` sort
fallback. This recency-based ordering appears in multiple places in the
UI, such as the project listing, the tags list, and even the
shortlog and log views.
Given two equal-dated refs, however, sorting the `HEAD` ref before
the non-`HEAD` ref provides more useful signal than merely sorting by
refname. For example, say we had "master" and "trunk" both pointing at
the same commit but "trunk" was `HEAD`, sorting "trunk" first helps
communicate its special status as the default branch that you'll check
out if you clone the repo.
Add `-HEAD` as a secondary sort key to the `git for-each-ref` call
in `git_get_heads_list()` to provide the desired behavior. The most
recently committed refs will appear first, but `HEAD`-ness will be used
as a tie-breaker. Note that `refname` is the implicit fallback sort key,
which means that two same-dated non-`HEAD` refs will continue to be
sorted in lexicographical order, as they are today.
Signed-off-by: Greg Hurrell <greg@hurrell.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper/test-userdiff.c')
0 files changed, 0 insertions, 0 deletions