diff options
author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2018-10-21 10:37:31 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-10-22 12:52:29 +0900 |
commit | 276b49ff3413434ec491db8fcb56485a71c6b6e7 (patch) | |
tree | 00a5f7f202a4c6bfd1b912c4aac73089fde459f0 /t/chainlint/subshell-here-doc.expect | |
parent | completion: collapse extra --no-.. options (diff) | |
download | tgif-276b49ff3413434ec491db8fcb56485a71c6b6e7.tar.xz |
completion: fix __gitcomp_builtin no longer consider extra options
__gitcomp_builtin() has the main completion list provided by
git xxx --git-completion-helper
but the caller can also add extra options that is not provided by
--git-completion-helper. The only call site that does this is "git
difftool" completion.
This support is broken by b221b5ab9b (completion: collapse extra
--no-.. options - 2018-06-06), which adds a special value "--" to mark
that the rest of the options can be hidden by default. The commit
forgets the fact that extra options are appended after
"$(git xxx --git-completion-helper)", i.e. after this "--", and will
be incorrectly hidden as well.
Prepend the extra options before "$(git xxx --git-completion-helper)"
to avoid this.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/chainlint/subshell-here-doc.expect')
0 files changed, 0 insertions, 0 deletions