diff options
| author |  Jonathan Nieder <jrnieder@gmail.com> | 2010-07-20 19:01:01 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2010-07-21 11:52:26 -0700 |
| commit | bdcaa325b47fcacfecb781a28801aafc249ba288 (patch) | |
| tree | 1b315f9d1d234d8c857d098683fc2849e5c8a3d8 /t/README | |
| parent | t/{t5541,lib-httpd}: replace problematic '!()' notation with test_must_fail (diff) | |
| download | tgif-bdcaa325b47fcacfecb781a28801aafc249ba288.tar.xz | |
t/README: correct an exception when breaking a && chain in tests
The correct advice should have been taken from c289c31 (t/t7006: ignore
return status of shell's unset builtin, 2010-06-02). A real-life issue
we experienced was with "unset", not with "export" (exporting an
unset variable may have similar portability issues, though).
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/README')
| -rw-r--r-- | t/README | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -259,11 +259,11 @@ Do: test ... That way all of the commands in your tests will succeed or fail. If - you must ignore the return value of something (e.g. the return - value of export is unportable) it's best to indicate so explicitly - with a semicolon: + you must ignore the return value of something (e.g., the return + after unsetting a variable that was already unset is unportable) it's + best to indicate so explicitly with a semicolon: - export HLAGH; + unset HLAGH; git merge hla && git push gh && test ... |