diff options
| author |  Jens Lehmann <Jens.Lehmann@web.de> | 2014-07-09 21:34:42 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-07-10 13:04:42 -0700 |
| commit | 00f6991d4bb35e76836d4ce8f2eaab3e4e3b20a7 (patch) | |
| tree | 6ba60abe20262d7a5b8fc1a8f04b1512c9eecfc9 /t/Makefile | |
| parent | t/Makefile: check helper scripts for non-portable shell commands too (diff) | |
| download | tgif-00f6991d4bb35e76836d4ce8f2eaab3e4e3b20a7.tar.xz | |
t/Makefile: always test all lint targets when running tests
Only the two targets "test-lint-duplicates" and "test-lint-executable" are
currently executed when running the test target. This was done on purpose
when the TEST_LINT variable was added in 81127d74 to avoid twisted shell
scripting by developers only to avoid false positives that might result
from the rather simple minded tests, e.g. test-lint-shell-syntax. But it
looks like it might be better to include all lint tests to help developers
to detect non portable shell constructs before the patch is sent to the
list and reviewed there.
Change the TEST_LINT variable to run all lint test unless the TEST_LINT
variable is overridden. If we hit false positives more often than helping
developers to avoid non-portable code (or add less accurate or slow tests
later) we could still fall back to exclude them like 81127d74 proposed.
Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/Makefile')
| -rw-r--r-- | t/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/Makefile b/t/Makefile index 7fa66928b7..43b15e36ae 100644 --- a/t/Makefile +++ b/t/Makefile @@ -13,7 +13,7 @@ TAR ?= $(TAR) RM ?= rm -f PROVE ?= prove DEFAULT_TEST_TARGET ?= test -TEST_LINT ?= test-lint-duplicates test-lint-executable +TEST_LINT ?= test-lint ifdef TEST_OUTPUT_DIRECTORY TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results |