summaryrefslogtreecommitdiff
path: root/submodule.c
diff options
context:
space:
mode:
authorLibravatar René Scharfe <l.s.r@web.de>2016-09-27 21:11:58 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-09-27 14:02:40 -0700
commitf937d78553ce22505543580ae7958d9f5ffeeb89 (patch)
treea6344bff6d36dda957aa9f0242ffa8ee47127a8b /submodule.c
parentuse strbuf_addstr() instead of strbuf_addf() with "%s", part 2 (diff)
downloadtgif-f937d78553ce22505543580ae7958d9f5ffeeb89.tar.xz
use strbuf_add_unique_abbrev() for adding short hashes, part 2
Call strbuf_add_unique_abbrev() to add abbreviated hashes to strbufs instead of taking detours through find_unique_abbrev() and its static buffer. This is shorter and a bit more efficient. 1eb47f167d65d1d305b9c196a1bb40eb96117cb1 already converted six cases, this patch covers three more. A semantic patch for Coccinelle is included for easier checking for new cases that might be introduced in the future. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule.c')
-rw-r--r--submodule.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/submodule.c b/submodule.c
index 95a7ac544b..1e28437a5a 100644
--- a/submodule.c
+++ b/submodule.c
@@ -374,7 +374,7 @@ void show_submodule_summary(FILE *f, const char *path,
find_unique_abbrev(one, DEFAULT_ABBREV));
if (!fast_backward && !fast_forward)
strbuf_addch(&sb, '.');
- strbuf_addstr(&sb, find_unique_abbrev(two, DEFAULT_ABBREV));
+ strbuf_add_unique_abbrev(&sb, two, DEFAULT_ABBREV);
if (message)
strbuf_addf(&sb, " %s%s\n", message, reset);
else