diff options
| author | Eric Wong <e@80x24.org> | 2019-10-06 23:30:27 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-10-07 10:20:09 +0900 |
| commit | d22245a2e360d2e708ca37169be8eb5a5899b98d (patch) | |
| tree | f1bde8f5da6ea424fa1f9538d6debd4b5fd6b5f4 /submodule-config.c | |
| parent | d0a48a0a1d0df49af2e5fd6a80b0d84776c285aa (diff) | |
hashmap_entry_init takes "struct hashmap_entry *"
C compilers do type checking to make life easier for us. So rely on that and update all hashmap_entry_init callers to take "struct hashmap_entry *" to avoid future bugs while improving safety and readability. Signed-off-by: Eric Wong <e@80x24.org> Reviewed-by: Derrick Stolee <stolee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule-config.c')
| -rw-r--r-- | submodule-config.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/submodule-config.c b/submodule-config.c index 4264ee216f..4aa02e280e 100644 --- a/submodule-config.c +++ b/submodule-config.c @@ -123,7 +123,7 @@ static void cache_put_path(struct submodule_cache *cache, unsigned int hash = hash_oid_string(&submodule->gitmodules_oid, submodule->path); struct submodule_entry *e = xmalloc(sizeof(*e)); - hashmap_entry_init(e, hash); + hashmap_entry_init(&e->ent, hash); e->config = submodule; hashmap_put(&cache->for_path, e); } @@ -135,7 +135,7 @@ static void cache_remove_path(struct submodule_cache *cache, submodule->path); struct submodule_entry e; struct submodule_entry *removed; - hashmap_entry_init(&e, hash); + hashmap_entry_init(&e.ent, hash); e.config = submodule; removed = hashmap_remove(&cache->for_path, &e, NULL); free(removed); @@ -147,7 +147,7 @@ static void cache_add(struct submodule_cache *cache, unsigned int hash = hash_oid_string(&submodule->gitmodules_oid, submodule->name); struct submodule_entry *e = xmalloc(sizeof(*e)); - hashmap_entry_init(e, hash); + hashmap_entry_init(&e->ent, hash); e->config = submodule; hashmap_add(&cache->for_name, e); } @@ -163,7 +163,7 @@ static const struct submodule *cache_lookup_path(struct submodule_cache *cache, oidcpy(&key_config.gitmodules_oid, gitmodules_oid); key_config.path = path; - hashmap_entry_init(&key, hash); + hashmap_entry_init(&key.ent, hash); key.config = &key_config; entry = hashmap_get(&cache->for_path, &key, NULL); @@ -183,7 +183,7 @@ static struct submodule *cache_lookup_name(struct submodule_cache *cache, oidcpy(&key_config.gitmodules_oid, gitmodules_oid); key_config.name = name; - hashmap_entry_init(&key, hash); + hashmap_entry_init(&key.ent, hash); key.config = &key_config; entry = hashmap_get(&cache->for_name, &key, NULL); |