diff options
author | Eric Sunshine <sunshine@sunshineco.com> | 2018-04-03 05:25:41 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-04-05 16:08:33 +0900 |
commit | b1801b85a32e21a7e83d165b029b5115ab0f8167 (patch) | |
tree | 707b0e2305042a24ec5862e1db4d6a25f217806e /show-index.c | |
parent | t2028: fix minor error and issues in newly-added "worktree move" tests (diff) | |
download | tgif-b1801b85a32e21a7e83d165b029b5115ab0f8167.tar.xz |
t2028: tighten grep expression to make "move worktree" test more robust
Following a rename of worktree "source" to "destination", the "move
worktree" test uses grep to verify that the output of "git worktree list
--porcelain" does not contain "source" (and does contain "destination").
Unfortunately, the grep expression is too loose and can match
unexpectedly. For example, if component of the test trash directory path
matches "source" (e.g. "/home/me/sources/git/t/trash*"), then the test
will be fooled into thinking that "source" still exists. Tighten the
expression to avoid such accidental matches.
While at it, drop an unused variable ("toplevel") from the test and
tighten a similarly too-loose expression in a related test.
Reported-by: Jens Krüger <Jens.Krueger@frm2.tum.de>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'show-index.c')
0 files changed, 0 insertions, 0 deletions