summaryrefslogtreecommitdiff
path: root/show-index.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2017-02-23 03:15:55 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-02-23 12:47:02 -0800
commit13b9a24e58f736b70e48846cf7e5b7cfa66c3fec (patch)
tree19431a4ebf5037f3dc4cf32cc72602c3107dde74 /show-index.c
parentident: handle NULL email when complaining of empty name (diff)
downloadtgif-13b9a24e58f736b70e48846cf7e5b7cfa66c3fec.tar.xz
ident: reject all-crud ident name
An ident name consisting of only "crud" characters (like whitespace or punctuation) is effectively the same as an empty one, because our strbuf_addstr_without_crud() will remove those characters. We reject an empty name when formatting a strict ident, but don't notice an all-crud one because our check happens before the crud-removal step. We could skip past the crud before checking for an empty name, but let's make it a separate code path, for two reasons. One is that we can give a more specific error message. And two is that unlike a blank name, we probably don't want to kick in the fallback-to-username behavior. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'show-index.c')
0 files changed, 0 insertions, 0 deletions