diff options
| author |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2019-03-25 11:14:18 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-04-02 09:54:59 +0900 |
| commit | dd605e4956903da2e375afe2e58beab2af39b7b8 (patch) | |
| tree | 3cdd534bd63f9efa91e51d1559369e8a1ac50026 /sha1dc_git.c | |
| parent | The third batch (diff) | |
| download | tgif-dd605e4956903da2e375afe2e58beab2af39b7b8.tar.xz | |
tests (rebase): spell out the `--keep-empty` option
This test wants to run `git rebase` with the `--keep-empty` option, but
it really only spelled out `--keep` and trusted Git's option parsing to
determine that this was a unique abbreviation of the real option.
However, Denton Liu contributed a patch series in
https://public-inbox.org/git/cover.1553354374.git.liu.denton@gmail.com/
that introduces a new `git rebase` option called `--keep-base`, which
makes this previously unique abbreviation non-unique.
Whether this patch series is accepted or not, it is actually a bad
practice to use abbreviated options in our test suite, because of the
issue that those unique option names are not guaranteed to stay unique
in the future.
So let's just not use abbreviated options in the test suite.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1dc_git.c')
0 files changed, 0 insertions, 0 deletions