diff options
author | Charles Bailey <cbailey32@bloomberg.net> | 2017-11-12 15:25:23 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-11-13 12:48:00 +0900 |
commit | 5555a2aa4bb004a24d8bea32051be0b56fb2532e (patch) | |
tree | bfa5f093fd5762c628f3a8d1749ef96ba0089f3c /sha1_file.c | |
parent | Git 2.12.5 (diff) | |
download | tgif-5555a2aa4bb004a24d8bea32051be0b56fb2532e.tar.xz |
t4201: make use of abbreviation in the test more robust
The test for '--abbrev' in t4201-shortlog.sh assumes that the commits
generated in the test can always be uniquely abbreviated to 5 hex digits
but this is not always the case. If you were unlucky and happened to run
the test at (say) Thu Jun 22 03:04:49 2017 +0000, you would find that
the first commit generated would collide with a tree object created
later in the same test.
This can be simulated in the version of t4201-shortlog.sh prior to this
commit by setting GIT_COMMITTER_DATE and GIT_AUTHOR_DATE to 1498100689
after sourcing test-lib.sh.
Change the test to test --abbrev=35 instead of --abbrev=5 to almost
completely avoid the possibility of a partial collision and add a call
to test_tick in the setup to make the test repeatable (the latter alone
is sufficient to make it robust enough).
Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1_file.c')
0 files changed, 0 insertions, 0 deletions