diff options
| author |  Thomas Rast <trast@student.ethz.ch> | 2010-07-24 16:49:04 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2010-07-25 21:57:23 -0700 |
| commit | 730220de8be669257287e9a1f5dde349ace5426a (patch) | |
| tree | 397acf0fb781bb98853ea4a5af3d50235ff876fe /server-info.c | |
| parent | Git 1.7.2 (diff) | |
| download | tgif-730220de8be669257287e9a1f5dde349ace5426a.tar.xz | |
Do not unquote + into ' ' in URLs
Since 9d2e942 (decode file:// and ssh:// URLs, 2010-05-23) the URL
logic unquotes escaped URLs. For the %2B type of escape, this is
conformant with RFC 2396. However, it also unquotes + into a space
character, which is only appropriate for the query strings in HTTP.
This notably broke fetching from the gtk+ repository.
We cannot just remove the corresponding code since the same
url_decode_internal() is also used by the HTTP backend to decode query
parameters. Introduce a new argument that controls whether the +
decoding happens, and use it only in the (client-side) url_decode().
Reported-by: Jasper St. Pierre <jstpierre@mecheye.net>
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'server-info.c')
0 files changed, 0 insertions, 0 deletions