diff options
| author |  Jeff King <peff@peff.net> | 2014-08-26 06:23:54 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-08-26 10:34:26 -0700 |
| commit | 2608c24940c80bf379937e4cefee75e2db79e008 (patch) | |
| tree | 0ca188483b8a15b6753ca0b90ef80bc4860ed4e1 /revision.c | |
| parent | log-tree: make add_name_decoration a public function (diff) | |
| download | tgif-2608c24940c80bf379937e4cefee75e2db79e008.tar.xz | |
log-tree: make name_decoration hash static
In the previous commit, we made add_name_decoration global
so that adders would not have to access the hash directly.
We now make the hash itself static so that callers _have_ to
add through our function, making sure that all additions go
through a single point. To do this, we have to add one more
accessor function: a way to lookup entries in the hash.
Since the only caller doesn't actually look at the returned
value, but rather only asks whether there is a decoration or
not, we could provide only a boolean "has_name_decoration".
That would allow us to make "struct name_decoration" local
to log-tree, as well.
However, it's unlikely to cause any maintainability harm
making the actual data public, and this interface is more
flexible if we need to look at decorations from other parts
of the code in the future.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/revision.c b/revision.c index f40ccf1426..46b9c349e8 100644 --- a/revision.c +++ b/revision.c @@ -473,7 +473,7 @@ static int rev_compare_tree(struct rev_info *revs, * If we are simplifying by decoration, then the commit * is worth showing if it has a tag pointing at it. */ - if (lookup_decoration(&name_decoration, &commit->object)) + if (get_name_decoration(&commit->object)) return REV_TREE_DIFFERENT; /* * A commit that is not pointed by a tag is uninteresting |