summaryrefslogtreecommitdiff
path: root/revision.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2017-04-10 20:30:23 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-04-16 17:48:00 -0700
commit22e5ae5c8e6859e5670a2c6bbf5798778373144c (patch)
tree5a6dad8f1db78298d29162cc2fc4e3d3e6b3fb56 /revision.c
parentconnect.c: stop conflating ssh command names and overrides (diff)
downloadtgif-22e5ae5c8e6859e5670a2c6bbf5798778373144c.tar.xz
connect.c: handle errors from split_cmdline
Commit e9d9a8a4d (connect: handle putty/plink also in GIT_SSH_COMMAND, 2017-01-02) added a call to split_cmdline(), but checks only for a non-zero return to see if we got any output. Since the function returns negative values (and a NULL argv) on error, we end up dereferencing NULL and segfaulting. Arguably we could report on the parsing error here, but it's probably not worth it. This is a best-effort attempt to see if we are using plink. So we can simply return here with "no, it wasn't plink" and let the shell actually complain about the bogus quoting. Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
0 files changed, 0 insertions, 0 deletions