diff options
author | Jonathan Tan <jonathantanmy@google.com> | 2020-09-01 15:28:09 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-09-02 14:39:25 -0700 |
commit | f24c30e0b6b13078d8fc7cd71b9989d28fd76610 (patch) | |
tree | 9b013a5a9bede34aacc64ccdb958ecb6505d826c /remote.c | |
parent | ec06b05568bb9dbb7333a5974b4512db18395674 (diff) |
wt-status: tolerate dangling marks
When a user checks out the upstream branch of HEAD, the upstream branch not being a local branch, and then runs "git status", like this: git clone $URL client cd client git checkout @{u} git status no status is printed, but instead an error message: fatal: HEAD does not point to a branch (This error message when running "git branch" persists even after checking out other things - it only stops after checking out a branch.) This is because "git status" reads the reflog when determining the "HEAD detached" message, and thus attempts to DWIM "@{u}", but that doesn't work because HEAD no longer points to a branch. Therefore, when calculating the status of a worktree, tolerate dangling marks. This is done by adding an additional parameter to dwim_ref() and repo_dwim_ref(). Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote.c')
-rw-r--r-- | remote.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/remote.c b/remote.c index bc46413e6a..b7460bd083 100644 --- a/remote.c +++ b/remote.c @@ -1558,7 +1558,7 @@ static void set_merge(struct branch *ret) strcmp(ret->remote_name, ".")) continue; if (dwim_ref(ret->merge_name[i], strlen(ret->merge_name[i]), - &oid, &ref) == 1) + &oid, &ref, 0) == 1) ret->merge[i]->dst = ref; else ret->merge[i]->dst = xstrdup(ret->merge_name[i]); |