diff options
author | Christian Couder <christian.couder@gmail.com> | 2017-08-16 14:40:36 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-08-16 09:40:33 -0700 |
commit | d3ba566342a4fd81b24d926efc35506d58e10a19 (patch) | |
tree | d4fd4eebafad9436ad9e1adb1b0751c23fe90436 /remote.c | |
parent | sub-process: refactor handshake to common function (diff) | |
download | tgif-d3ba566342a4fd81b24d926efc35506d58e10a19.tar.xz |
sub-process: print the cmd when a capability is unsupported
In handshake_capabilities() we use warning() when a capability
is not supported, so the exit code of the function is 0 and no
further error is shown. This is a problem because the warning
message doesn't tell us which subprocess cmd failed.
On the contrary if we cannot write a packet from this function,
we use error() and then subprocess_start() outputs:
initialization for subprocess '<cmd>' failed
so we can know which subprocess cmd failed.
Let's improve the warning() message, so that we can know which
subprocess cmd failed.
Helped-by: Lars Schneider <larsxschneider@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote.c')
0 files changed, 0 insertions, 0 deletions