diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-04-06 16:00:37 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-04-06 12:57:06 -0700 |
commit | ea7811b37e0e6fabb2a410475f198eab33110dcf (patch) | |
tree | 2d8c56deabe9a57a1da218783e714484cadc170a /refs | |
parent | git-send-email: refactor duplicate $? checks into a function (diff) | |
download | tgif-ea7811b37e0e6fabb2a410475f198eab33110dcf.tar.xz |
git-send-email: improve --validate error output
Improve the output we emit on --validate error to:
* Say "FILE:LINE" instead of "FILE: LINE", to match "grep -n",
compiler error messages etc.
* Don't say "patch contains a" after just mentioning the filename,
just leave it at "FILE:LINE: is longer than[...]. The "contains a"
sounded like we were talking about the file in general, when we're
actually checking it line-by-line.
* Don't just say "rejected by sendemail-validate hook", but combine
that with the system_or_msg() output to say what exit code the hook
died with.
I had an aborted attempt to make the line length checker note all
lines that were longer than the limit. I didn't think that was worth
the effort, but I've left in the testing change to check that we die
as soon as we spot the first long line.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs')
0 files changed, 0 insertions, 0 deletions