diff options
| author |  Michael Haggerty <mhagger@alum.mit.edu> | 2017-09-08 15:51:48 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-09-09 03:18:04 +0900 |
| commit | 22b09cdfadf7a48f6503fddf51082c66541cf1d6 (patch) | |
| tree | 9f53ba2a59f35664e58fd6d2e359dd31aa78ba1d /refs/files-backend.c | |
| parent | files_pack_refs(): use a reference transaction to write packed refs (diff) | |
| download | tgif-22b09cdfadf7a48f6503fddf51082c66541cf1d6.tar.xz | |
prune_refs(): also free the linked list
At least since v1.7, the elements of the `refs_to_prune` linked list
have been leaked. Fix the leak by teaching `prune_refs()` to free the
list elements as it processes them.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs/files-backend.c')
| -rw-r--r-- | refs/files-backend.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/refs/files-backend.c b/refs/files-backend.c index 3475c6f8a2..60031fe3ae 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -1057,11 +1057,17 @@ static void prune_ref(struct files_ref_store *refs, struct ref_to_prune *r) strbuf_release(&err); } -static void prune_refs(struct files_ref_store *refs, struct ref_to_prune *r) +/* + * Prune the loose versions of the references in the linked list + * `*refs_to_prune`, freeing the entries in the list as we go. + */ +static void prune_refs(struct files_ref_store *refs, struct ref_to_prune **refs_to_prune) { - while (r) { + while (*refs_to_prune) { + struct ref_to_prune *r = *refs_to_prune; + *refs_to_prune = r->next; prune_ref(refs, r); - r = r->next; + free(r); } } @@ -1148,7 +1154,7 @@ static int files_pack_refs(struct ref_store *ref_store, unsigned int flags) packed_refs_unlock(refs->packed_ref_store); - prune_refs(refs, refs_to_prune); + prune_refs(refs, &refs_to_prune); strbuf_release(&err); return 0; } |